Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Mentor and Volunteer Section #26

Merged
merged 7 commits into from
Nov 23, 2023
Merged

Feature: Mentor and Volunteer Section #26

merged 7 commits into from
Nov 23, 2023

Conversation

alexanderl19
Copy link
Contributor

@alexanderl19 alexanderl19 commented Nov 20, 2023 •
edited
Loading

Mentor and Volunteer Stand Section

The top and bottom of the stand are seperate elements and the bottom expands as needed to accommodate additional text. The stands are placed side by side when space allows or vertically.

Safari 2023-11-22 at 01 56 49@2x

@alexanderl19 alexanderl19 linked an issue Nov 20, 2023 that may be closed by this pull request
Set up mentor and volunteer section #14
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit fb75209

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit fb75209

@alexanderl19 alexanderl19 marked this pull request as ready for review November 22, 2023 09:57
samderanova
samderanova requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, just a few minor issues!

apps/site/src/app/(home)/page.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/MentorVolunteer/MentorVolunteer.tsx Outdated Show resolved Hide resolved
apps/site/src/app/(home)/sections/MentorVolunteer/Stand.tsx Show resolved Hide resolved
apps/site/src/assets/backgrounds/landing-background.png Outdated Show resolved Hide resolved
apps/site/src/lib/components/Button/Button.tsx Show resolved Hide resolved
apps/site/src/app/(home)/sections/MentorVolunteer/MentorVolunteer.tsx Outdated Show resolved Hide resolved
@samderanova
Copy link
Contributor

Might just be me, but the stands still seem to be pretty close.

image

samderanova
samderanova requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep nagging you on this, but there's one more issue with the stands.

apps/site/src/app/(home)/sections/MentorVolunteer/MentorVolunteer.tsx Show resolved Hide resolved
samderanova
samderanova approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Will be squash merging

@samderanova samderanova merged commit 7510e9e into main Nov 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up mentor and volunteer section
2 participants
@alexanderl19 @samderanova